Add table definitions for tags and recents #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedre
commented
Nov 23, 2025
| deleted INTEGER NOT NULL DEFAULT 0, | ||
| CHECK (deleted IN (0, 1)), | ||
| UNIQUE(bookmark_local_id, tag_id), | ||
| FOREIGN KEY(tag_id) REFERENCES tags(local_id) |
Contributor
Author
There was a problem hiding this comment.
intentionally have no ON DELETE because we need to be able to handle deletes softly
| CREATE TABLE bookmark_tags ( | ||
| local_id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT, | ||
| bookmark_local_id TEXT NOT NULL, | ||
| bookmark_type TEXT NOT NULL, -- 'PAGE' or 'AYAH' |
Contributor
Author
There was a problem hiding this comment.
wdyt of this - make it a number or split this into two tables or?
Collaborator
There was a problem hiding this comment.
It looks good to me the way it's right now
mohamede1945
approved these changes
Nov 24, 2025
Collaborator
mohamede1945
left a comment
mohamede1945
left a comment
There was a problem hiding this comment.
Looks good mashaa'Allah.
| @@ -0,0 +1,12 @@ | |||
| CREATE TABLE bookmark_tags ( | |||
Collaborator
There was a problem hiding this comment.
are these going to be called tags or collections to match the backend and web?
Contributor
Author
There was a problem hiding this comment.
renaming to collections - جزاكم الله خيراً
| CREATE TABLE bookmark_tags ( | ||
| local_id INTEGER NOT NULL PRIMARY KEY AUTOINCREMENT, | ||
| bookmark_local_id TEXT NOT NULL, | ||
| bookmark_type TEXT NOT NULL, -- 'PAGE' or 'AYAH' |
Collaborator
There was a problem hiding this comment.
It looks good to me the way it's right now
persistence/src/commonMain/sqldelight/com/quran/shared/persistence/last_pages.sq
Outdated
Show resolved
Hide resolved
ahmedre
force-pushed
the
tags_and_recents
branch
from
1256d22 to
b9cf9bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.