-
-
Notifications
You must be signed in to change notification settings - Fork 529
[QF-3518] open learning plans for guest users #2589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yousefdergham
wants to merge
12
commits into
testing
Choose a base branch
from
QF-3518-open-learning-plans
base: testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+213
−400
Open
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c9a1f84
Enhance user enrollment API by introducing EnrollmentMethod type and …
yousefdergham 45cbb0b
Refactor course enrollment handling by introducing useEnrollUser hook…
yousefdergham c0cd5e3
Added "Start here" text to the English localization file and removed …
yousefdergham 2e333d1
Remove guest enrollment hooks and Redux slice to streamline authentic…
yousefdergham 809ba0d
Remove unused styles for the NotEnrolledLink component from Syllabus.…
yousefdergham a03191f
Refactor course enrollment logic by updating the useEnrollUser hook t…
yousefdergham 4de3b31
Update useEnrollUser hook to return success status directly from enro…
yousefdergham b138823
Update call-to-action button text in English localization for the Qur…
yousefdergham e7ce359
Refactor handleFetchSuccess function in LessonPage to simplify its de…
yousefdergham 8d69165
Refactor enrollment method constants in EnrollmentMethod type to use …
yousefdergham bbcacb3
Refactor useEnrollUser hook to simplify enrollment logic by directly …
yousefdergham 99b6293
Refactor course enrollment logic in StatusHeader and LessonPage compo…
yousefdergham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
src/components/Course/NotEnrolledNotice/NotEnrolledNotice.module.scss
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation key
'start-learning'is still defined in the locale file but is no longer used anywhere in the code after the simplification of theStartOrContinueLearningcomponent. This is dead code that should be removed fromlocales/en/learn.json.