Skip to content

Fix default factory #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
half-potato wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix default factory #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions diff_gaussian_rasterization/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

import json
import dacite
from dataclasses import dataclass, asdict
from dataclasses import dataclass, asdict, field
from typing import NamedTuple
import torch.nn as nn
import torch
Expand Down Expand Up @@ -202,7 +202,7 @@ def set_value(self, key, value):

@dataclass
class SortSettings:
queue_sizes : SortQueueSizes = SortQueueSizes()
queue_sizes : SortQueueSizes = field(default_factory=SortQueueSizes)
sort_mode : SortMode = SortMode.GLOBAL
sort_order : GlobalSortOrder = GlobalSortOrder.Z_DEPTH

Expand All @@ -225,8 +225,8 @@ def set_value(self, key, value):

@dataclass
class ExtendedSettings:
sort_settings : SortSettings = SortSettings()
culling_settings : CullingSettings = CullingSettings()
sort_settings : SortSettings = field(default_factory=SortSettings)
culling_settings : CullingSettings = field(default_factory=CullingSettings)
load_balancing : bool = False
proper_ewa_scaling : bool = False
def to_dict(self):
Expand Down