Fix force_shrink_members_to_current_member/1 typespec#640
Open
visciang wants to merge 1 commit into
Open
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
There was a problem hiding this comment.
Pull request overview
This PR corrects the return typespec for force_shrink_members_to_current_member/1 in ra_server_proc, aligning it with the actual return values produced by gen_statem_safe_call/3 (which can return timeout and {error, ...} in addition to the success value).
Changes:
- Update
force_shrink_members_to_current_member/1typespec from-> okto-> safe_call_ret(ok).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix
force_shrink_members_to_current_member/1typespecTypes of Changes
Checklist
CONTRIBUTING.mddocument