Skip to content

Fix force_shrink_members_to_current_member/1 typespec#640

Open
visciang wants to merge 1 commit into
rabbitmq:mainfrom
visciang:main
Open

Fix force_shrink_members_to_current_member/1 typespec#640
visciang wants to merge 1 commit into
rabbitmq:mainfrom
visciang:main

Conversation

@visciang

Copy link
Copy Markdown
Contributor

Proposed Changes

Fix force_shrink_members_to_current_member/1 typespec

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • Mandatory: I (or my employer/client) have have signed the CA (see https://github.com/rabbitmq/cla)
  • I have read the CONTRIBUTING.md document
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@mergify

mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the return typespec for force_shrink_members_to_current_member/1 in ra_server_proc, aligning it with the actual return values produced by gen_statem_safe_call/3 (which can return timeout and {error, ...} in addition to the success value).

Changes:

  • Update force_shrink_members_to_current_member/1 typespec from -> ok to -> safe_call_ret(ok).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants