Skip to content

lowercase header key in README responder example for Rack 3 compatibility #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
santib merged 2 commits into from
Dec 30, 2025
Merged

lowercase header key in README responder example for Rack 3 compatibility #705

santib merged 2 commits into from
Dec 30, 2025
+3 −3

Conversation

@r-plus
Copy link
Contributor

@r-plus r-plus commented Dec 24, 2025

Rack 3 required lowercase header key.

Response header keys can no longer include uppercase characters.

https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md

This PR fixed throttled_responder example in README for Rack 3 & 2 compatible.

this is Rack::Lint error when use.

Puma caught this error: uppercase character in header name: RateLimit-Limit (Rack::Lint::LintError)

@santib
Copy link
Collaborator

santib commented Dec 30, 2025

thank you!

@santib santib merged commit 77195a5 into rack:main Dec 30, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grzuy grzuy grzuy approved these changes

@santib santib santib approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r-plus @santib @grzuy