Automated Resyntax fixes

[resyntax-ci]

Resyntax fixed 20 issues in 7 files.

• Fixed 5 occurrences of unless-expression-in-for-loop-to-unless-keyword
• Fixed 4 occurrences of let-to-define
• Fixed 3 occurrences of map-to-for
• Fixed 3 occurrences of when-expression-in-for-loop-to-when-keyword
• Fixed 1 occurrence of and-let-to-cond
• Fixed 1 occurrence of named-let-loop-to-for-in-range
• Fixed 1 occurrence of nested-when-to-compound-when
• Fixed 1 occurrence of cond-let-to-cond-define
• Fixed 1 occurrence of instantiate-to-new

[rfindler]

This doesn't seem ideal.

[rfindler]

I removed the (IMO) questionable commit.

[github-actions]

Resyntax analyzed 7 files in this pull request and has added suggestions.

[github-actions]

named-let-loop-to-for-in-range: This named let expression is equivalent to a for loop that uses in-range.

Suggested change

	(let loop ([dy (- (/ quadrant-size 2))])
	(when (< dy h)
	(send dc set-alpha 1)
	(send dc set-brush palaka-color 'solid)
	(send dc draw-rectangle dx dy quadrant-size quadrant-size)
	(send dc set-brush "white" 'solid)
	(draw-one-palaka dc dx dy)
	(loop (+ dy quadrant-size)))))
	(for ([dy (in-range (- (/ quadrant-size 2)) h quadrant-size)])
	(send dc set-alpha 1)
	(send dc set-brush palaka-color 'solid)
	(send dc draw-rectangle dx dy quadrant-size quadrant-size)
	(send dc set-brush "white" 'solid)
	(draw-one-palaka dc dx dy)))

Debugging details

Textual replacement

(line-replacement
  #:new-lines
    '#("    (for ([dy (in-range (- (/ quadrant-size 2)) h quadrant-size)])"
       "      (send dc set-alpha 1)"
       "      (send dc set-brush palaka-color 'solid)"
       "      (send dc draw-rectangle dx dy quadrant-size quadrant-size)"
       "      (send dc set-brush \"white\" 'solid)"
       "      (draw-one-palaka dc dx dy)))")
  #:original-lines
    '#("    (let loop ([dy (- (/ quadrant-size 2))])"
       "      (when (< dy h)"
       "        (send dc set-alpha 1)"
       "        (send dc set-brush palaka-color 'solid)"
       "        (send dc draw-rectangle dx dy quadrant-size quadrant-size)"
       "        (send dc set-brush \"white\" 'solid)"
       "        (draw-one-palaka dc dx dy)"
       "        (loop (+ dy quadrant-size)))))")
  #:start-line 28)

Syntactic replacement

(syntax-replacement
  #:introduction-scope #<procedure:...and/syntax-local.rkt:148:2>
  #:new-syntax
    #<syntax:/home/runner/.local/share/racket/9.1.0.1/pkgs/resyntax/default-recommendations/loops/named-let-loopification.rkt:40:2 (for ((dy (in-range (- (/ quadrant-size 2)) h quadrant-size))) (send dc set-alpha 1) (send dc set-brush palaka-color (quote solid)) (send dc draw-rectangle dx dy quadrant-size quadrant-size) (send dc set-brush "white" (quote solid)) (draw-one-palaka dc ...>
  #:original-syntax
    #<syntax:drracket-core-lib/drracket/private/palaka.rkt:28:4 (let loop ((dy (- (/ quadrant-size 2)))) (when (< dy h) (send dc set-alpha 1) (send dc set-brush palaka-color (quote solid)) (send dc draw-rectangle dx dy quadrant-size quadrant-size) (send dc set-brush "white" (quote solid)) (draw-one-palaka dc dx dy) ...>
  #:source
    (file-source
     #<path:/home/runner/work/drracket/drracket/drracket-core-lib/drracket/private/palaka.rkt>)
  #:uses-universal-tagged-syntax? #f)

[github-actions]

if-let-to-cond: cond with internal definitions is preferred over if with let, to reduce nesting

Suggested change

	(if (<= counter 0)
	(fail)
	(let ([result (pred)])
	(or result
	(begin
	(sleep step)
	(loop (- counter step))))))))
	(cond
	[(<= counter 0) (fail)]
	[else
	(define result (pred))
	(or result
	(begin
	(sleep step)
	(loop (- counter step))))])))

Debugging details

Textual replacement

(line-replacement
  #:new-lines
    '#("    (cond"
       "      [(<= counter 0) (fail)]"
       "      [else"
       "       (define result (pred))"
       "       (or result"
       "           (begin"
       "             (sleep step)"
       "             (loop (- counter step))))])))")
  #:original-lines
    '#("    (if (<= counter 0)"
       "        (fail)"
       "        (let ([result (pred)])"
       "          (or result"
       "              (begin"
       "                (sleep step)"
       "                (loop (- counter step))))))))")
  #:start-line 127)

Syntactic replacement

(syntax-replacement
  #:introduction-scope #<procedure:...and/syntax-local.rkt:148:2>
  #:new-syntax
    #<syntax:/home/runner/.local/share/racket/9.1.0.1/pkgs/resyntax/default-recommendations/let-replacement/cond-let-replacement.rkt:47:2 (cond ((<= counter 0) (fail)) (else (define result (pred)) (or result (begin (sleep step) (loop (- counter step))))))>
  #:original-syntax
    #<syntax:drracket-test/tests/drracket/private/no-fw-test-util.rkt:127:4 (if (<= counter 0) (fail) (let ((result (pred))) (or result (begin (sleep step) (loop (- counter step))))))>
  #:source
    (file-source
     #<path:/home/runner/work/drracket/drracket/drracket-test/tests/drracket/private/no-fw-test-util.rkt>)
  #:uses-universal-tagged-syntax? #f)