Automated Resyntax fixes #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These list element variable definitions can be expressed more succinctly with `match-define`. Note that the suggested replacement raises an error if the list contains more elements than expected.
The `begin` in this definition can be extracted into the surrounding definition context.
This `for-each` operation can be replaced with a `for` loop.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Using `cond` allows converting `let` to internal definitions, reducing nesting
rfindler
force-pushed
the
autofix-128-1
branch
from
970d30f to
c89f9a3
Compare
Member
|
I rebased on master and just dropped commits that had conflicts. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Resyntax analyzed 3 files in this pull request and has added suggestions.
Comment on lines
+139
to
+141
| (let ([res (syntax->datum stx)]) | ||
| (hash-set! ht res stx) | ||
| res)])) |
Contributor
There was a problem hiding this comment.
cond-let-to-cond-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
Suggested change
| (let ([res (syntax->datum stx)]) | |
| (hash-set! ht res stx) | |
| res)])) | |
| (define res (syntax->datum stx)) | |
| (hash-set! ht res stx) | |
| res])) |
Debugging details
Textual replacement
(line-replacement
#:new-lines
'#(" (define res (syntax->datum stx))"
" (hash-set! ht res stx)"
" res]))")
#:original-lines
'#(" (let ([res (syntax->datum stx)])"
" (hash-set! ht res stx)"
" res)]))")
#:start-line 139)Syntactic replacement
(syntax-replacement
#:introduction-scope #<procedure:...and/syntax-local.rkt:148:2>
#:new-syntax
#<syntax:/home/runner/.local/share/racket/9.1.0.1/pkgs/resyntax/default-recommendations/let-replacement/cond-let-replacement.rkt:36:2 (cond ((list? obj) (let ((res (map loop obj))) (hash-set! ht res stx) res)) ((pair? obj) (let ((res (cons (loop (car obj)) (loop (cdr obj))))) (hash-set! ht res stx) res)) ((vector? obj) (let ((res (list->vector (map loop (vector->list obj))))) (hash-se...>
#:original-syntax
#<syntax:drracket-core-lib/drracket/private/syncheck-debug.rkt:125:14 (cond ((list? obj) (let ((res (map loop obj))) (hash-set! ht res stx) res)) ((pair? obj) (let ((res (cons (loop (car obj)) (loop (cdr obj))))) (hash-set! ht res stx) res)) ((vector? obj) (let ((res (list->vector (map loop (vector->list obj))))) (hash-se...>
#:source
(file-source
#<path:/home/runner/work/drracket/drracket/drracket-core-lib/drracket/private/syncheck-debug.rkt>)
#:uses-universal-tagged-syntax? #f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 7 files.
unless-expression-in-for-loop-to-unless-keywordlet-to-definelist-element-definitions-to-match-definefor-each-to-formap-to-forwhen-expression-in-for-loop-to-when-keywordand-let-to-condnamed-let-loop-to-for-in-rangedefine-begin-extraction