Fence 2373 qa logging #463
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds logging and testing enhancements for React Native QA, with substantial additions to the radar SDK's tagging functionality and trip order management capabilities.
- Adds comprehensive user tag management APIs with methods to get, set, add, and remove tags
- Introduces new trip order functionality for tracking order-related events and notifications
- Implements enhanced logging throughout SDK method calls for better debugging and QA testing
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| RadarSDKTests/RadarSDKTests.m | Adds extensive test coverage for user tag functionality and API integration |
| RadarSDKTests/RadarAPIHelperMock.h/.m | Enhances mock helper to capture API request details for testing |
| RadarSDK/RadarSettings.h/.m | Implements user tag storage and management functionality |
| RadarSDK/Include/Radar.h | Adds public API methods for tag management |
| RadarSDK/Radar.m | Implements tag APIs and adds comprehensive logging to all public methods |
| RadarSDK/Include/RadarTripOrder.h | Defines new trip order model with status tracking |
| RadarSDK/RadarTripOrder.m | Implements trip order parsing and serialization |
| RadarSDK/RadarTrip.m/.h | Adds trip order support to existing trip model |
| RadarSDK/RadarAPIClient.m | Integrates user tags into API calls and beacon region notifications |
| RadarSDK/RadarNotificationHelper.h/.m | Refactors notification management with improved campaign handling |
| RadarSDK/RadarBeaconManager.h/.m | Adds beacon notification registration capabilities |
| Multiple version files | Updates SDK version to 3.22.0-beta.1 |
| return @"motorbike"; | ||
| default: | ||
| return @"unknown"; | ||
| if (mode == 0) { |
There was a problem hiding this comment.
The magic number 0 should be replaced with a named constant like RadarRouteModeUnknown or RadarRouteModeNone to improve code readability and maintainability.
| return @"motorbike"; | ||
| default: | ||
| return @"unknown"; | ||
| if (mode == 0) { |
There was a problem hiding this comment.
I'm a little confused on the rationale behind this change
There was a problem hiding this comment.
RadarRouteMode is a flag enum, so they might pass a value of 5 to represent foot | car, and this method would return "unknown". this change causes it to return "foot,car"
added logging during react native qa