-
Notifications
You must be signed in to change notification settings - Fork 31
FENCE 2472: Configurable motion permission prompt #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,7 @@ - (instancetype)initWithDict:(NSDictionary *)dict { | |
| _useForegroundLocationUpdatedAtMsDiff = NO; | ||
| _useNotificationDiff = NO; | ||
| _syncAfterSetUser = NO; | ||
| _delayedMotionUsage = NO; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why an sdk config instead of a initialize option?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if the sdk config request fails, could that trigger the motion prompt?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh because useMotion is a SDK config? |
||
|
|
||
| if (dict == nil) { | ||
| return self; | ||
|
|
@@ -93,6 +94,11 @@ - (instancetype)initWithDict:(NSDictionary *)dict { | |
| _syncAfterSetUser = [(NSNumber *)syncAfterSetUserObj boolValue]; | ||
| } | ||
|
|
||
| NSObject *delayedMotionUsageObj = dict[@"delayedMotionUsage"]; | ||
| if (delayedMotionUsageObj && [delayedMotionUsageObj isKindOfClass:[NSNumber class]]) { | ||
| _delayedMotionUsage = [(NSNumber *)delayedMotionUsageObj boolValue]; | ||
| } | ||
|
|
||
| return self; | ||
| } | ||
|
|
||
|
|
@@ -110,7 +116,7 @@ - (NSDictionary *)dictionaryValue { | |
| dict[@"useForegroundLocationUpdatedAtMsDiff"] = @(_useForegroundLocationUpdatedAtMsDiff); | ||
| dict[@"useNotificationDiff"] = @(_useNotificationDiff); | ||
| dict[@"syncAfterSetUser"] = @(_syncAfterSetUser); | ||
|
|
||
| dict[@"delayedMotionUsage"] = @(_delayedMotionUsage); | ||
| return dict; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this be true if
requestMotionActivityPermissionis never called and delayedMotionUsage is not set