Open
Conversation
Combines with --killsig to allow time for a graceful child shutdown during procServ shutdown. By default, no change. If a killsig other than SIGKILL is selected, along with a non-zero grace period, then when procServ receives SIGTERM: 1. Send killsig to child 2. wait up to grace-period 3. If child remains, then issue SIGKILL 4. procServ exit
Co-authored-by: google-labs-jules[bot]
Owner
Author
|
@mdavidsaver, @ericonr: please have a look. |
Collaborator
|
Look good to me. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated and completed version of @mdavidsaver's grace-period PR #70.
(rebase, add documentation, include in procServUtils, fix Python 3.12 compat issue)
Add
--grace-period(short-g) flag. Combine with--killsigto allow time for a graceful child shutdown during procServ shutdown.By default, no change.
If a killsig other than
SIGKILLis selected along with a non-zero grace period, then when procServ receives SIGTERM:SIGKILLThere are some whitespace changes in separate commits.
This PR will be squashed before merging.
(closes #70)