Skip to content

Try evaluating code with parentheses before without parentheses #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Try evaluating code with parentheses before without parentheses #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions inst/NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
htmlwidgets 1.5.1.9000
-------------------------------------------------------

* Fixed an issue with passing named function declarations to `JS()` and `onRender()` (introduced by v1.4). (#356)

htmlwidgets 1.5.1
-------------------------------------------------------

Expand Down
4 changes: 2 additions & 2 deletions inst/www/htmlwidgets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,13 +249,13 @@
function tryEval(code) {
var result = null;
try {
result = eval(code);
result = eval("(" + code + ")");
} catch(error) {
if (!error instanceof SyntaxError) {
throw error;
}
try {
result = eval("(" + code + ")");
result = eval(code);
} catch(e) {
if (e instanceof SyntaxError) {
throw error;
Expand Down