Warn when deleting roles bound to groups #16070
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6844
Role deletion only warned about bound users, not groups. Now warns about both.
Occurred changes and/or fixed issues
roleDeletionCheck.jsmixin to collectgroupPrincipalNamefrom role bindingsboundkey with plural handling for users/groups combinationsusersBoundtranslation keyTechnical notes summary
Groups are identified via
groupPrincipalNameon role bindings (vsuserNamefor users). The warning message now uses a nested ICU plural format to handle all combinations:Areas or cases that should be tested
Test cases:
Tested in Chrome.
Areas which could experience regressions
Screenshot/Video
Checklist
Admin,Standard UserandUser BaseWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
download.cypress.io/usr/local/bin/node /usr/local/bin/node index.js --exec install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.