-
Notifications
You must be signed in to change notification settings - Fork 620
Minor fixes for macOS and powerpc #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
randombit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPUID changes look fine
Thank you, I will make changes according to your suggestions today and rebase the PR. |
|
@randombit I have dropped two commits, as advised, switched to |
|
@barracuda156 Format checks are failing, you should be able to just apply the patch printed in the failing job |
|
@randombit I will check that, thanks. |
Fix for clang format error that occurred during Botan CI process
|
@barracuda156 LGTM please squash and then this can merge |
A few fixes to allow the build on older macOS versions.
<sys/random.h>may need <sys/types.h>, otherwise the build breaks on system headers, complaining thatu_inthas not been declared.