Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Conversation

@jarmak-nv
Copy link
Contributor

@jarmak-nv jarmak-nv commented Jul 27, 2023

Description

This PR adds a simple raster -> vector polygonization notebook.

  • Each pixel is converted into a square polygon
  • A GeoDataFrame is made from the polygons
  • Data is read from the Raster and converted to cuDF columns

This notebook serves to be a test-showcase for cuProj. It uses Sentinel-2 imagery and each tile generates about 120M polygons.

The cuML section is largely for testing/showcasing another RAPIDS integration but I don't feel it's necessary (esp since it needs work.)

Regardless of status on the reviews, the has been applied until legal approval. It may be better for us to put this in notebook-contrib as well to prevent rasterio from being a notebook dependency.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jarmak-nv jarmak-nv added the DO NOT MERGE Hold off on merging; see PR for details label Jul 27, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the Python Related to Python code label Jul 27, 2023
@harrism
Copy link
Member

harrism commented Nov 20, 2024

@jarmak-nv any reason not to get this merged?

@jarmak-nv
Copy link
Contributor Author

@jarmak-nv any reason not to get this merged?

My hesitation largely stems from testing/dependencies - if we exclude it from notebook tests and don't add the dependencies to our containers then I'm fine with merging, but in doing so we may end up with it not functioning at some point and not realizing it due to the lack of testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DO NOT MERGE Hold off on merging; see PR for details Python Related to Python code

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants