Skip to content

Conversation

@jameslamb
Copy link
Member

While working on #832 , I've noticed a couple of small opportunities for improvement. This has those updates.

  • puts floors on all conda-installed libraries
    • for faster environment solves
    • and reduced risk of "surprise! fell back to a super old version" types of bugs
  • removes installations of gha-tools only used for rapids-logger
    • fewer GitHub network requests = fewer flaky CI failures
  • updates pre-commit hooks with pre-commit autoupdate
  • cleans up excess empty lines in Dockerfiles

Dockerfile Outdated
"python=${PYTHON_VER}.*" \
"cuda-version=${CUDA_VER%.*}.*" \
ipython \
'ipython>=9' \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at this! Trying a floor made it clear that the openssl pinning from #810 made these images fall back to an older ipython!

#13 59.19 error    libmamba Could not solve for environment specs
#13 59.19     The following packages are incompatible
#13 59.19     ├─ ipython >=9 * is installable with the potential options
#13 59.19     │  ├─ ipython [9.0.0|9.0.2|...|9.8.0] would require
#13 59.19     │  │  └─ python >=3.11 * with the potential options
#13 59.19     │  │     ├─ python [3.10.7|3.10.8|3.11.0] would require
#13 59.19     │  │     │  └─ openssl >=1.1.1s,<1.1.2a *, which can be installed;
#13 59.19     │  │     ├─ python [3.11.0|3.11.1|...|3.14.2], which can be installed;
#13 59.19     │  │     ├─ python [3.14.0rc1|3.14.0rc2|3.14.0rc3] would require
#13 59.19     │  │     │  └─ _python_rc =* *, which does not exist (perhaps a missing channel);
#13 59.19     │  │     └─ python [3.10.6|3.11.0] would require
#13 59.19     │  │        └─ openssl >=1.1.1q,<1.1.2a *, which can be installed;
#13 59.19     │  └─ ipython [9.0.0|9.0.2|...|9.8.0] would require
#13 59.19     │     └─ __win =* *, which is missing on the system;
#13 59.19     ├─ openssl ==3.6.0 * is not installable because it conflicts with any installable versions previously reported;
#13 59.19     └─ python =3.10 * is installable with the potential options
#13 59.19        ├─ python [3.10.7|3.10.8|3.11.0], which can be installed (as previously explained);
#13 59.19        ├─ python [3.10.6|3.11.0], which can be installed (as previously explained);
#13 59.19        ├─ python [3.10.0|3.10.1|...|3.10.9] conflicts with any installable versions previously reported;
#13 59.19        ├─ python [3.10.0|3.10.1|3.10.2] would require
#13 59.19        │  └─ openssl >=1.1.1l,<1.1.2a *, which can be installed;
#13 59.19        ├─ python 3.10.4 would require
#13 59.19        │  └─ openssl >=1.1.1n,<1.1.2a *, which can be installed;
#13 59.19        └─ python 3.10.5 would require
#13 59.19           └─ openssl >=1.1.1o,<1.1.2a *, which can be installed.

(build link)

That's exactly the type of thing the pinning is supposed to help us discover, this makes me happy 😁

Looks like in recent successful builds we got ipython==8.37.0, so I'll try moving the pin back to that.

...
#13 38.74   + ipython                                8.37.0  pyh8f84b5b_0                                  conda-forge     639kB
...

(build link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant