fix(ci): force python3 symlink in Velox deps image - #417
Closed
Avinash-Raj wants to merge 1 commit into
Closed
Conversation
bdice
reviewed
Sep 7, 2026
| run: | | ||
| sed -i 's/ARM_BUILD_TARGET:-"local"/ARM_BUILD_TARGET:-"generic"/' velox/scripts/setup-helper-functions.sh | ||
|
|
||
| # TODO: Remove once facebookincubator/velox makes the python symlink idempotent. |
Contributor
There was a problem hiding this comment.
Compare this to prestodb/presto#28434, it seems simpler.
Contributor
Author
There was a problem hiding this comment.
Yes, but we make sure that the base image symlinks python3 to /usr/bin/python
Contributor
Author
There was a problem hiding this comment.
Verified that the base image contain the /usr/bin/python symlink by default and it points to the python3 -> python3.9
$ docker run --rm quay.io/centos/centos:stream9 ls -la /usr/bin/python
lrwxrwxrwx 1 root root 9 Aug 14 13:30 /usr/bin/python -> ./python3
Contributor
Author
|
Closing this since the fix was already landed on upstream https://github.com/facebookincubator/velox/blob/main/scripts/docker/centos-multi.dockerfile#L110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ln -s $(which python3) /usr/bin/pythonbecomesln -sfn $(which python3) /usr/bin/python.Motivation
Nightly velox-nightly failed on all four deps jobs (
cuda12.9/13.1 x amd64/arm64):https://github.com/rapidsai/velox-testing/actions/runs/34085672229
That line is in
facebookincubator/veloxscripts/docker/centos-multi.dockerfileafterinstall_build_prerequisites && install_velox_deps_from_dnf. On current CentOS Stream 9,/usr/bin/pythoncan already exist (the RPM that owns it ispython-unversioned-command, notpython3-pip/python3-devel). Plainln -sthen fails.ln -sfncreates the python -> python3 link when missing and replaces it when present. Same pattern as the existingARM_BUILD_TARGETcheckout patch. Drop this step once upstream makes the symlink idempotent.Test plan
ln -sfn $(which python3) /usr/bin/pythonrather thanln -s