✨ feat: added pydantic model for manifest validation #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptadev21
requested review from
amitsingh21,
ankitrgadiya and
sharmayajush
and removed request for
a team and
sharmayajush
guptadev21
force-pushed
the
feat/manifest-validation
branch
7 times, most recently
from
45143e6 to
c186df2
Compare
ankitrgadiya
reviewed
Sep 8, 2025
guptadev21
force-pushed
the
feat/manifest-validation
branch
3 times, most recently
from
0f1d84e to
889383f
Compare
guptadev21
force-pushed
the
feat/manifest-validation
branch
from
1f9e28d to
9af30e9
Compare
guptadev21
force-pushed
the
feat/manifest-validation
branch
from
4699832 to
6b4218f
Compare
guptadev21
force-pushed
the
feat/manifest-validation
branch
from
9eca000 to
d135e2b
Compare
- Added new models for Daemon, Deployment, Disk, ManagedService, Network, Organization, Package, Project, Secret, StaticRoute, and User. - Introduced a new utils module for shared base classes and constants. - Updated __init__.py to import all models directly into the main namespace. - Enhanced validation logic in models using Pydantic's field validators and model validators. - Bumped version to 0.3.0 to reflect the addition of new features and models.
- Removed unused imports and commented-out code in utils.py. - Updated walk_pages and walk_pages_async functions to yield items directly instead of using Munch.
- Updated test cases in `test_network.py` to assert against `Network` and `NetworkList` models. - Refactored `test_organization.py` to utilize `Organization` model for assertions. - Changed assertions in `test_package.py` to validate against `Package` and `PackageList` models. - Modified `test_project.py` to use `Project` and `ProjectList` models for response validation. - Updated `test_secret.py` to assert against `Secret` and `SecretList` models. - Refactored `test_staticroute.py` to validate responses using `StaticRoute` and `StaticRouteList` models. - Changed `test_user.py` to assert against user model attributes instead of Munch. - Improved mock data usage across tests for consistency and clarity.
guptadev21
force-pushed
the
feat/manifest-validation
branch
from
d135e2b to
2c282db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What’s new in this PR
💡 Why this matters
resolves https://github.com/rapyuta-robotics/rapyuta_io/issues/922