RavenDB-25423 Boolean method negation callsites diagnoser and fixer #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scooletz
force-pushed
the
bool-methods-diagnostics
branch
from
fdd96eb to
f9a7b09
Compare
Scooletz
changed the title
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.hibernatingrhinos.com/issue/RavenDB-25423/Raven.CodeAnalysis-add-a-rule-for-method-negation
This PR introduces a diagnoser and a fixer for callsites that uses bool returning methods. To increase readability,
we should prefer the following
over this one
This PR does not allow opting out of this behavior in any other way than
#pragmaor[Supress...]