Repository navigation
fix: support variable-length channel args in make visualizer - #280
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
raveriss
marked this pull request as ready for review
February 5, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
visualizerduMakefilequi rejetait--channels(GNU Make interprète--*comme option) et ne supportait pas un nombre variable d'arguments pour les canaux.Description
wordlistpour récupérer tous les arguments après<subject> <run>et construire dynamiquement l'option--channelssi nécessaire.--channels(pour le casmake -- visualizer ...) afin que la cible accepte à la foismake visualizer 1 3 C3 Cz C4etmake -- visualizer 1 3 --channels C3 Cz C4.Makefile(ciblevisualizer).Testing
poetry run pytest -q(577 tests), tous passés.pre-commit/black --check/isort --check-only/ruff/mypy/pip-audit: toutes les vérifications automatiques sont passées après mise à jour temporaire depippourpip-audit.make covont produit un rapport et ont atteint la couverture totale requise (90% global), avec génération decoverage.jsonetcoverage.xmlréussie.make -n visualizer 1 3 C3 Cz C4etmake -n -- visualizer 1 3 --channels C3 Cz C4, toutes deux valides.Codex Task