Skip to content

Conversation

@artivilla
Copy link
Contributor

@artivilla artivilla commented Nov 23, 2025

Description

feat: update UI element path for Color Filters checkbox in macOS Tahoe. resolving #22834

Screencast

demo link: https://cap.link/d4hfbytwj5mwm1g

Checklist

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: toggle-grayscale Issues related to the toggle-grayscale extension platform: macOS labels Nov 23, 2025
@raycastbot
Copy link
Collaborator

Thank you for your contribution! 🎉

🔔 @zcsabbagh you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10 business days.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 23, 2025

Greptile Overview

Greptile Summary

This PR updates the toggle-grayscale extension to support macOS Tahoe by changing the UI element path in the AppleScript from group 2 to group 3. The change is minimal and targeted.

Key changes:

  • Updated AppleScript UI element path to locate Color Filters checkbox in macOS Tahoe's System Settings
  • Added PR author as contributor to package.json
  • Added changelog entry documenting the macOS Tahoe support

Issues found:

  • CHANGELOG entry uses actual date 2025-11-22 instead of required {PR_MERGE_DATE} template string

Confidence Score: 4/5

  • Safe to merge after fixing the CHANGELOG date format
  • The core functionality change is simple and well-targeted (UI path update for macOS Tahoe). Only issue is CHANGELOG format violation which is easily fixable.
  • CHANGELOG.md needs the date format corrected from 2025-11-22 to {PR_MERGE_DATE}

Important Files Changed

File Analysis

Filename Score Overview
extensions/toggle-grayscale/CHANGELOG.md 3/5 Added new changelog entry with incorrect date format (uses actual date instead of template string)
extensions/toggle-grayscale/package.json 5/5 Added PR author as contributor - appropriate and correct change
extensions/toggle-grayscale/src/toggle-grayscale.ts 5/5 Updated UI element path from group 2 to group 3 to support macOS Tahoe, removed trailing whitespace

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@@ -1,9 +1,11 @@
# Toggle Grayscale Changelog

## [Supports macOS Tahoe] - 2025-11-22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Use {PR_MERGE_DATE} template string instead of actual date

Suggested change
## [Supports macOS Tahoe] - 2025-11-22
## [Supports macOS Tahoe] - {PR_MERGE_DATE}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: toggle-grayscale Issues related to the toggle-grayscale extension platform: macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants