fix: PAT expiry handling, date filters, and settings view borders#1671
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR upgrades ChangesApsara upgrade and date filter expansion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/apps/admin/src/utils/transform-query.ts (1)
133-152:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMap
group_bythroughfieldNameMappingin the admin path too.Filters and sorts already rename UI field keys before building the request, but
groupBystill sends the rawquery.group_byvalues. That leaves grouped admin queries inconsistent with the SDK variants in this PR whenever the backend expects mapped field names.Suggested fix
const rqlRequest = create(RQLRequestSchema, { filters, - groupBy: query.group_by || [], + groupBy: (query.group_by || []).map( + field => fieldNameMapping?.[field] ?? field + ), offset: query.offset || 0, limit: query.limit || defaultLimit, sort: transformSort(query.sort || [], fieldNameMapping) || [], search: query.search || '' });
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 04803451-3d12-4397-ad0f-03b4a034a013
⛔ Files ignored due to path filters (1)
web/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (14)
web/apps/admin/package.jsonweb/apps/admin/src/utils/transform-query.tsweb/apps/client-demo/package.jsonweb/sdk/package.jsonweb/sdk/react/utils/transform-query.tsweb/sdk/react/views-new/general/general-view.module.cssweb/sdk/react/views-new/pat/pat-details-view.module.cssweb/sdk/react/views-new/pat/pat-details-view.tsxweb/sdk/react/views-new/preferences/components/preferences-row.module.cssweb/sdk/react/views-new/profile/profile-view.module.cssweb/sdk/react/views-new/projects/project-details-view.tsxweb/sdk/react/views-new/security/security-view.module.cssweb/sdk/react/views-new/sessions/sessions-view.module.cssweb/sdk/utils/transform-query.ts
Coverage Report for CI Build 26880447270Coverage remained the same at 43.153%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
@raystack/apsarato1.0.0-rc.12across SDK, admin, and client-demo packageseqinto a[start of day, next day)gte/ltrange anchored to the user's local timezone, fixing the off-by-one-day RQL query and the impossible exact-timestampeqmatch in all threetransform-queryutilsfromNow, and disable the Update action (button + menu item) with an explanatory tooltip when the token is expired0.5pxand remove the trailing border on the last section/row via:last-child