Skip to content

chore: update Org role titles for brevity#1705

Merged
whoAbhishekSah merged 3 commits into
mainfrom
change-role-titles
Jun 17, 2026
Merged

chore: update Org role titles for brevity#1705
whoAbhishekSah merged 3 commits into
mainfrom
change-role-titles

Conversation

@whoAbhishekSah

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jun 17, 2026 4:27am

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 63926bbc-f725-4778-aa9c-f4b025e92092

📥 Commits

Reviewing files that changed from the base of the PR and between 5a5895b and 8873825.

📒 Files selected for processing (1)
  • internal/bootstrap/schema/schema.go
✅ Files skipped from review due to trivial changes (1)
  • internal/bootstrap/schema/schema.go

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Updated organization role display names to be shorter and less redundant: “Organization Owner” → “Owner”, “Organization Access Manager” → “Access Manager”, “Organization Viewer” → “Member”, and “Organization Group Viewer” → “Group Viewer”.
    • Role permissions and behavior remain unchanged.

Walkthrough

Four Title strings in PredefinedRoles within internal/bootstrap/schema/schema.go are shortened by removing the "Organization" prefix. Role Name values, permissions, and scopes are not modified.

Changes

Role Title Updates

Layer / File(s) Summary
PredefinedRoles title string renames
internal/bootstrap/schema/schema.go
Title fields for four organization roles drop the "Organization" prefix: "Organization Owner""Owner", "Organization Access Manager""Access Manager", "Organization Viewer""Member", "Organization Group Viewer""Group Viewer".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
internal/bootstrap/schema/schema.go (1)

350-357: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Duplicate role Name constant shared with the "Viewer" role.

The "Group Viewer" role at line 351–352 uses Name: RoleOrganizationViewer, which is identical to the "Viewer" role at line 343–344. Role names must be unique identifiers for API operations, permissions checks, and role lookups. Having two roles with the same name breaks that invariant and can cause runtime failures.

A new role name constant should be defined (e.g., RoleOrganizationGroupViewer = "app_organization_group_viewer") and assigned to this role.

🔧 Proposed fix to define and use a unique role name constant

Add a new constant near the existing role constants at the top of the file:

  const (
    RoleOrganizationViewer  = "app_organization_viewer"
    RoleOrganizationManager = "app_organization_manager"
    RoleOrganizationOwner   = "app_organization_owner"

+   RoleOrganizationGroupViewer = "app_organization_group_viewer"

    RoleProjectOwner   = "app_project_owner"

Then update the "Group Viewer" role definition:

  {
    Title: "Group Viewer",
-   Name:  RoleOrganizationViewer,
+   Name:  RoleOrganizationGroupViewer,
    Permissions: []string{
      "app_organization_get",
    },
    Scopes: []string{OrganizationNamespace},
  },

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 45ae9120-16d2-485f-a844-84057097ca89

📥 Commits

Reviewing files that changed from the base of the PR and between 36ed818 and 56df59f.

📒 Files selected for processing (1)
  • internal/bootstrap/schema/schema.go

@coveralls

coveralls commented Jun 16, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27665761249

Coverage remained the same at 43.631%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37036
Covered Lines: 16159
Line Coverage: 43.63%
Coverage Strength: 12.39 hits per line

💛 - Coveralls

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
internal/bootstrap/schema/schema.go (1)

343-353: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Member title is overwritten by a duplicate role key

Line 343 introduces Title: "Member", but Lines 350-353 define another PredefinedRoles entry with the same Name: RoleOrganizationViewer. Since role migration/upsert is keyed by Name, the later entry overwrites the earlier one, so "Member" will not be the persisted final title.

Please make these entries uniquely keyed (distinct Name) or collapse them into a single definition so the intended title change actually takes effect.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1cbd424-849b-428a-a446-104e19e6402e

📥 Commits

Reviewing files that changed from the base of the PR and between 56df59f and 5a5895b.

📒 Files selected for processing (1)
  • internal/bootstrap/schema/schema.go

@whoAbhishekSah whoAbhishekSah merged commit 2defcbd into main Jun 17, 2026
8 checks passed
@whoAbhishekSah whoAbhishekSah deleted the change-role-titles branch June 17, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants