Address solution load performance#369
Merged
Merged
Conversation
razzmatazz
force-pushed
the
address-roslyn-solution-load-slowness
branch
from
b236d58 to
ea56266
Compare
razzmatazz
force-pushed
the
address-roslyn-solution-load-slowness
branch
from
ea56266 to
5584a0a
Compare
… resolve tfms per project
razzmatazz
force-pushed
the
address-roslyn-solution-load-slowness
branch
from
5584a0a to
6890a44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up solution load by reading target frameworks directly from project XML (
XDocument) instead of always invoking MSBuildProjectCollection, and fanning the probes out withAsync.Parallel. Falls back toProjectCollectiononly when the TFM value contains a property reference or is absent from the project file (e.g. declared inDirectory.Build.props).Before: 58 × ~114 ms serial
ProjectCollectionevaluations ≈ 6.6 sAfter: parallel sub-millisecond XML reads + at most a few serialised MSBuild fallbacks ≈ < 50 ms
Investigated in
plans/roslyn-buildhost-solution-load-perf.md.🤖 Generated with eca