You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The sslscan target was originally marked at as pnony in the PR that introduced static building. The problem with marking it as non-phony is that it means that if (for example), you run make, then if you run a make static it will see that sslscan already exists so won't rebuild it (so you'll still have the dynamically build version), which isn't desirible. It's a pain if you have to keep running make clean, because that also blows away the compiled OpenSSL stuff.
I needd to see if there's a nice way to allow both make and make static to work properly with a non-phony sslscan - although I have a feeling it will involve some more ugly bash code :/
~rbsec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
sslscanis a real file, it should be removed from the.PHONYlistso that
make static installwon't try to build a non-static version.