VPAAMP-261: AAMP_EVENT_TUNE_TIME_METRICS dispatched before PLAYING state event

[Vinish100]

Reason for change: Sent the tunetime metrics event from the progress callback to time it always after the player has moved to PLAYING state. In TuneFailure case, it will be sent during Stop call. PLAYING state event is used by VIPA and EPG to measure total tune time and hence should not be delayed.
Test Procedure: Confirm from logs that tune time metrics event is sent after state=PLAYING event in tune success. Ensure the event is still sent in tune fail case
Risks: Low

[Copilot]

Pull request overview

This PR changes the tune-time metrics dispatch flow so AAMP_EVENT_TUNE_TIME_METRICS is emitted after the player transitions to PLAYING, by deferring event dispatch until MonitorProgress() observes eSTATE_PLAYING. It also refactors the tune-metrics event/profiler interfaces to pass/move the JSON payload more directly.

Changes:

• Queue tune-time metrics JSON in PrivateInstanceAAMP and dispatch it from MonitorProgress() once the state is PLAYING (with a TuneFail fallback path).
• Update TuneTimeMetricsEvent to take the metrics JSON by value and move it into the event object.
• Simplify GetTuneTimeMetricAsJson() signature by removing the explicit licenseAcqNWTime parameter and deriving it from existing buckets.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
priv_aamp.cpp	Defers tune metrics event dispatch to MonitorProgress() when state becomes PLAYING; updates TuneFail/LogTuneComplete behavior; adds additional state-transition logs.
priv_aamp.h	Updates SendTuneMetricsEvent() signature and adds mTuneTimeMetricData storage for deferred dispatch.
AampEvent.h	Changes TuneTimeMetricsEvent constructor to take JSON payload by value (movable).
AampEvent.cpp	Implements the updated TuneTimeMetricsEvent constructor using move semantics.
AampProfiler.h	Updates GetTuneTimeMetricAsJson() signature to remove licenseAcqNWTime.
AampProfiler.cpp	Computes lnw from PROFILE_BUCKET_LA_NETWORK directly and updates callers accordingly.
test/utests/fakes/FakeAampEvent.cpp	Updates fake TuneTimeMetricsEvent constructor to match the new signature and move behavior.
test/utests/tests/PrivAampTests/PrivAampTests.cpp	Adjusts the SendTuneMetricsEventTest call site to the new signature.
test/utests/tests/AampProfilerTests/AampProfilerTests.cpp	Updates the GetTuneTimeMetricAsJsonTest call site to the new signature.

Comments suppressed due to low confidence (2)

priv_aamp.cpp:3388

• SendTuneMetricsEvent() relies on std::move(mTuneTimeMetricData) to "automatically" clear the member and uses empty() elsewhere to ensure the event is sent only once. A moved-from std::string is only guaranteed to be valid, not empty, so this can lead to duplicate sends or stale data. Use an explicit reset (e.g., exchange with an empty string and move the exchanged value into the event) so the member is deterministically cleared after dispatch.

	// mTuneTimeMetricData is moved to constructor which automatically clears the mTuneTimeMetricData
	// after sending the event, so that next tune will have fresh data and avoid any confusion.
	TuneTimeMetricsEventPtr e = std::make_shared<TuneTimeMetricsEvent>(std::move(mTuneTimeMetricData), GetSessionId());

	AAMPLOG_TRACE("PrivateInstanceAAMP: Sending TuneTimeMetric event: %s", e->getTuneMetricsData().c_str());
	SendEvent(e,AAMP_EVENT_ASYNC_MODE);

priv_aamp.cpp:4129

• mTuneTimeMetricData is only populated via profiler.TuneEnd() when mManifestUrl != FAKE_TUNE_URL, but SendTuneMetricsEvent() is still called whenever eventAvailStatus is true. Because mTuneTimeMetricData persists across tunes, this can dispatch stale metrics from a previous tune (or an empty string) in the FAKE_TUNE_URL path. Clear mTuneTimeMetricData at the start of tune-end handling (TuneFail/LogTuneComplete and/or tune start), and consider only sending the event when the freshly-generated JSON string is non-empty.

	if(mManifestUrl != FAKE_TUNE_URL)
	{
		profiler.TuneEnd(mTuneMetrics, mAppName,(mbPlayEnabled?STRFGPLAYER:STRBGPLAYER), mPlayerId, mPlayerPreBuffered, durationSeconds, activeInterfaceWifi, mFailureReason, eventAvailStatus ? &mTuneTimeMetricData : NULL);
	}
	if (eventAvailStatus)
	{
		// Send the tune time metrics event as the progress event might not fire here.
		SendTuneMetricsEvent();
	}

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

priv_aamp.cpp:4134

• TuneFail sets mTuneMetricDataPending and immediately calls SendTuneMetricsEvent(), while MonitorProgress() can also call SendTuneMetricsEvent() when it sees the pending flag. With only load()/store() this can race and/or dispatch the tune-metrics event twice (and concurrently move from mTuneTimeMetricData). Use an atomic exchange-style check (e.g., if (mTuneMetricDataPending.exchange(false)) ...) around the send path, and synchronize access to mTuneTimeMetricData so only one thread consumes it.

		bool eventAvailStatus = IsEventListenerAvailable(AAMP_EVENT_TUNE_TIME_METRICS);
		profiler.TuneEnd(mTuneMetrics, mAppName,(mbPlayEnabled?STRFGPLAYER:STRBGPLAYER), mPlayerId, mPlayerPreBuffered, durationSeconds, activeInterfaceWifi, mFailureReason, eventAvailStatus ? &mTuneTimeMetricData : NULL);
		if (eventAvailStatus)
		{
			mTuneMetricDataPending.store(true);
			// Send the tune time metrics event as the progress event will not fire here.
			SendTuneMetricsEvent();
		}