Skip to content

VPAAMP-102: Fix duplicate res metric key in drmMetadata networkMetrics and documentation#1491

Merged
pstroffolino merged 3 commits into
dev_sprint_25_2from
feature/VPAAMP-102
May 28, 2026
Merged

VPAAMP-102: Fix duplicate res metric key in drmMetadata networkMetrics and documentation#1491
pstroffolino merged 3 commits into
dev_sprint_25_2from
feature/VPAAMP-102

Conversation

@srikanthreddybijjam-comcast
Copy link
Copy Markdown
Contributor

Reason for change: Modified res override with dns and updated Documentation.
Test Procedure: Refer Jira ticket VPAAMP-102
Priority: P1

Comment thread AAMP-UVE-API.md Outdated
Comment thread AAMP-UVE-API.md Outdated
Comment thread AAMP-UVE-API.md Outdated
@srikanthreddybijjam-comcast srikanthreddybijjam-comcast force-pushed the feature/VPAAMP-102 branch 3 times, most recently from bbce1de to c5bb1d4 Compare May 26, 2026 10:56
@Vinish100 Vinish100 requested a review from Copilot May 27, 2026 08:16
Copy link
Copy Markdown
Contributor

@Vinish100 Vinish100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a duplicate networkMetrics JSON key in DRM metadata telemetry by renaming the curl “resolve” metric key from res (conflicting with HTTP response) to dns, and updates unit-test validation and public UVE documentation accordingly.

Changes:

  • Fix UpdateLicenseMetrics() to emit dns (DNS resolve time) instead of a duplicate res key.
  • Add/extend test plumbing to capture networkMetrics JSON from DrmMetaDataEvent and validate all expected keys/values.
  • Update AAMP-UVE-API.md to document the corrected networkMetrics schema and examples.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
drm/AampDRMLicManager.cpp Fixes the duplicated JSON key by emitting dns for resolve timing and clarifies key meanings.
test/utests/fakes/FakeAampEvent.cpp Allows tests to intercept setNetworkMetricData() via the global mock delegate.
test/utests/mocks/MockDrmMetaDataEvent.h Adds setNetworkMetricData() to the mock so tests can capture the JSON payload.
test/utests/tests/AampDRMLicManagerTests/AampDRMLicManagerTestCases.cpp Adds a new test asserting the complete networkMetrics keyset and values.
AAMP-UVE-API.md Updates API documentation to reflect the corrected networkMetrics schema and removes the key collision.

Comment thread drm/AampDRMLicManager.cpp
…s and documentation

Reason for change: Modified res override with dns
Test Procedure: Refer jira ticket VPAAMP-102
Priority: P1

Signed-off-by: srikanthreddybijjam-comcast <srikanthreddybijjam.2000@gmail.com>
@pstroffolino pstroffolino merged commit 7803fa4 into dev_sprint_25_2 May 28, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants