Bringup VPAAMP-245: Negative Latency value logged while HLS linear pl…#1497
Merged
Merged
Conversation
pstroffolino
force-pushed
the
feature/VPAAMP-245_bringback
branch
from
a628824 to
6a30b3b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates PrivateInstanceAAMP::MonitorProgress() to prevent negative live-latency values during TSB-less linear HLS playback by deferring the start/end = -1 (XRE sentinel) assignment until after HLS latency is computed, and adds a unit regression test to guard against recurrence.
Changes:
- Move the TSB-less linear
start/end = -1override to after live latency calculation inMonitorProgress(). - Add a regression unit test validating
GetCurrentLatencyMs()is never negative for TSB-less linear HLS playback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
priv_aamp.cpp |
Reorders the TSB-less sentinel assignment to avoid corrupting HLS live latency computation. |
test/utests/tests/PrivAampTests/PrivAampTests.cpp |
Adds a regression test asserting live latency is non-negative for the affected scenario. |
Comment on lines
+2724
to
+2727
| // If TSB is not available for linear playback, send -1 for start and end | ||
| // so that XRE detects this as TSB-less playback. | ||
| // Override the above logic when mEnableSeekableRange is set for third-party apps. | ||
| if (!ISCONFIGSET_PRIV(eAAMPConfig_EnableSeekRange) && (mContentType == ContentType_LINEAR && !mFogTSBEnabled && !IsLocalAAMPTsb())) |
Comment on lines
+1709
to
+1712
| /** | ||
| * @brief Regression test for Positive Live latency value. | ||
| * | ||
| * Verifies that live latency is never negative during TSB-less linear HLS |
psiva01
added a commit
that referenced
this pull request
May 26, 2026
……" (#1496)" (#1497) Reason for Change: Updates PrivateInstanceAAMP::MonitorProgress() to prevent negative live-latency values during TSB-less linear HLS playback by deferring the start/end = -1 (XRE sentinel) assignment until after HLS latency is computed, and adds a unit regression test to guard against recurrence. Changes: Move the TSB-less linear start/end = -1 override to after live latency calculation in MonitorProgress(). Add a regression unit test validating GetCurrentLatencyMs() is never negative for TSB-less linear HLS playback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ayback (…" (#1496)"
This reverts commit 1bfaaa2.