RDKEMW-18286: [Xione UK][VIPA]Parental PIN: 1–2 seconds of video preview visible before PIN screen on parental pin linear channels#1502
Open
ALSAMEEMA wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses RDKEMW-18286 by ensuring the Rialto video sink’s show-video-window property is forced to FALSE as early as possible (and reinforced before state changes) when videoMuted is enabled, to prevent a brief video preview from appearing before the parental PIN UI.
Changes:
- Set
show-video-window=FALSEonrialtomsevideosinkimmediately after sink creation whenvideoMutedis already true. - Reinforce
show-video-window=FALSEon the Rialto video sink duringConfigurePipeline()prior to pipeline state transitions. - Minor whitespace-only changes in
bus_message().
Comments suppressed due to low confidence (1)
middleware/InterfacePlayerRDK.cpp:2341
- This newly added conditional/logging block is indented with large runs of spaces and doesn’t match the surrounding formatting in SetupStream, making the code hard to scan. Please re-indent it to follow the file’s established tab/brace alignment.
if (interfacePlayerPriv->gstPrivateContext->videoMuted)
{
MW_LOG_MIL("InterfacePlayerRDK - %s: setting show-video-window=FALSE "
"at creation time (videoMuted=%d)",
GST_ELEMENT_NAME(vidsink),
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+450
to
+455
| MW_LOG_MIL("InterfacePlayerRDK - ConfigurePipeline: reinforcing " | ||
| "show-video-window=FALSE on %s (videoMuted=%d)", | ||
| GST_ELEMENT_NAME(vidsink), | ||
| interfacePlayerPriv->gstPrivateContext->videoMuted); | ||
| g_object_set(vidsink, "show-video-window", FALSE, NULL); | ||
| } |
Comment on lines
+2332
to
+2336
| // RDKEMW-18286: Set show-video-window=FALSE at sink creation time. | ||
| // This is the EARLIEST possible point. The Rialto delegate will queue | ||
| // this (m_videoMuteQueued=true) and apply it server-side when the | ||
| // source attaches — which happens BEFORE the pipeline goes to PLAYING | ||
| // and BEFORE any frame can be decoded. |
Comment on lines
+2332
to
+2344
| // RDKEMW-18286: Set show-video-window=FALSE at sink creation time. | ||
| // This is the EARLIEST possible point. The Rialto delegate will queue | ||
| // this (m_videoMuteQueued=true) and apply it server-side when the | ||
| // source attaches — which happens BEFORE the pipeline goes to PLAYING | ||
| // and BEFORE any frame can be decoded. | ||
| if (interfacePlayerPriv->gstPrivateContext->videoMuted) | ||
| { | ||
| MW_LOG_MIL("InterfacePlayerRDK - %s: setting show-video-window=FALSE " | ||
| "at creation time (videoMuted=%d)", | ||
| GST_ELEMENT_NAME(vidsink), | ||
| interfacePlayerPriv->gstPrivateContext->videoMuted); | ||
| g_object_set(vidsink, "show-video-window", FALSE, NULL); | ||
| } |
Comment on lines
+4432
to
4435
|
|
||
|
|
||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Reinforce show-video-window before pipeline state change, and set show-video-window=FALSE at sink creation time. This is the EARLIEST possible point. The Rialto delegate will queue this (m_videoMuteQueued=true) and apply it server-side when the source attaches — which happens BEFORE the pipeline goes to PLAYING and BEFORE any frame can be decoded.
Test Procedure: Refer Ticket
Priority: P1
Risks: Low