Skip to content

RDKB-64184, RDKB-65468 : Update minimum NI memory limit to 30MB#91

Merged
GoutamD2905 merged 1 commit into
developfrom
feature/update-min-ni-memlimit
Jun 19, 2026
Merged

RDKB-64184, RDKB-65468 : Update minimum NI memory limit to 30MB#91
GoutamD2905 merged 1 commit into
developfrom
feature/update-min-ni-memlimit

Conversation

@SanthoshGujulvajagadeesh

Copy link
Copy Markdown
Contributor

Reason for change: Updated minimum NI memory limit to 30MB

Test Procedure:
Should not able to set Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.NetworkIntelligence.MemoryLimit
less than 30MB

Risks: Low
Priority: P1

Signed-off-by: Santhosh_GujulvaJagadeesh@comcast.com

@SanthoshGujulvajagadeesh SanthoshGujulvajagadeesh requested a review from a team as a code owner June 19, 2026 06:39
Copilot AI review requested due to automatic review settings June 19, 2026 06:39
@SanthoshGujulvajagadeesh SanthoshGujulvajagadeesh requested a review from a team as a code owner June 19, 2026 06:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the minimum allowed Network Intelligence (NI) memory limit to 30MB to prevent configuration below this threshold and keep runtime recovery behavior aligned with the new baseline.

Changes:

  • Increased NI minimum memory hard limit constant from 25MB to 30MB in the DML layer.
  • Updated the NI default memory hard limit in the CPU/memory recovery script from 25MB to 30MB.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
source/AdvSecurityDml/cosa_adv_security_dml.c Raises the enforced minimum NI memory limit to 30MB in the DML parameter handling.
scripts/advsec_cpu_mem_recovery.sh Raises the script’s default NI memory hard limit to 30MB (and should clamp persisted values to match).
Comments suppressed due to low confidence (1)

scripts/advsec_cpu_mem_recovery.sh:54

  • ni_max_rss from syscfg overrides the new 30MB default without validation. If an older device has a persisted value < 30 (or a non-numeric value), the recovery logic will keep using it, which diverges from the DML minimum and can cause unnecessary restarts. Clamp the syscfg value to >= 30 and ignore invalid values.
ni_max_rss=$(syscfg get Advsecurity_NetworkIntelligenceMemoryLimit)
if [ "$ni_max_rss" != "" ]; then
    NI_MEM_HARD_LIMIT=$ni_max_rss
fi

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/AdvSecurityDml/cosa_adv_security_dml.c
@GoutamD2905 GoutamD2905 merged commit 41c7e3b into develop Jun 19, 2026
12 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants