RDKB-64184, RDKB-65468 : Update minimum NI memory limit to 30MB#91
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the minimum allowed Network Intelligence (NI) memory limit to 30MB to prevent configuration below this threshold and keep runtime recovery behavior aligned with the new baseline.
Changes:
- Increased NI minimum memory hard limit constant from 25MB to 30MB in the DML layer.
- Updated the NI default memory hard limit in the CPU/memory recovery script from 25MB to 30MB.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/AdvSecurityDml/cosa_adv_security_dml.c | Raises the enforced minimum NI memory limit to 30MB in the DML parameter handling. |
| scripts/advsec_cpu_mem_recovery.sh | Raises the script’s default NI memory hard limit to 30MB (and should clamp persisted values to match). |
Comments suppressed due to low confidence (1)
scripts/advsec_cpu_mem_recovery.sh:54
ni_max_rssfrom syscfg overrides the new 30MB default without validation. If an older device has a persisted value < 30 (or a non-numeric value), the recovery logic will keep using it, which diverges from the DML minimum and can cause unnecessary restarts. Clamp the syscfg value to >= 30 and ignore invalid values.
ni_max_rss=$(syscfg get Advsecurity_NetworkIntelligenceMemoryLimit)
if [ "$ni_max_rss" != "" ]; then
NI_MEM_HARD_LIMIT=$ni_max_rss
fi
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GoutamD2905
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Updated minimum NI memory limit to 30MB
Test Procedure:
Should not able to set Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.NetworkIntelligence.MemoryLimit
less than 30MB
Risks: Low
Priority: P1
Signed-off-by: Santhosh_GujulvaJagadeesh@comcast.com