RDKEAPPRT - 795 Factory reset is not removing installed apps, application catalogue credentials,saved WiFi details, Audio and Video settings #202
Conversation
…on catalogue credentials,saved WiFi details, Audio and Video settings
There was a problem hiding this comment.
Pull request overview
This PR updates the Ref UI version to 6.0.14 and changes the Factory Reset flow to rely on the Warehouse plugin’s resetDevice() (defaulting to WAREHOUSE_CLEAR) so that factory reset more thoroughly clears device state (e.g., installed apps / credentials / settings) compared to the previous UI-driven cleanup + reboot sequence.
Changes:
- Bump Ref UI version from 6.0.13 to 6.0.14 in package config and app settings.
- Simplify factory reset confirmation logic to end with
Warehouse.resetDevice()instead of performing multiple targeted resets and a direct reboot. - Change Warehouse API
resetDevice()default reset type toWAREHOUSE_CLEAR.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bolt/package-configs/com.rdkcentral.refui.json | Version bump to 6.0.14. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FactoryResetConfirmationScreen.js | Factory reset flow now delegates device clearing to Warehouse resetDevice(). |
| accelerator-home-ui/src/api/WarehouseApis.js | Changes default reset type for resetDevice() to WAREHOUSE_CLEAR. |
| accelerator-home-ui/settings.json | Version bump to 6.0.14. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
accelerator-home-ui/src/api/WarehouseApis.js:128
resetDevice()resolves and then immediately callsreject(false)unconditionally (missingelse/return). This makes the promise logic incorrect and can cause confusing behavior for callers that rely on rejection for failures.
resetDevice(resetType = "WAREHOUSE_CLEAR", suppressReboot = false) {
return new Promise((resolve, reject) => {
let params = { resetType: resetType, suppressReboot: suppressReboot}
this.INFO(this.callsign + " resetDevice params: " + JSON.stringify(params));
this.thunder.call(this.callsign, 'resetDevice', params).then(result => {
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
accelerator-home-ui/src/api/WarehouseApis.js:128
- Inside
resetDevice(), the.then()handler callsresolve(...)but then unconditionally callsreject(false)on the next line. Even though subsequent Promise settlements are ignored by JS, this is misleading and makes the control flow harder to reason about (and can mask future changes if additional logic is added). Use an explicitelse/returnto only reject on failure.
resetDevice(resetType = "WAREHOUSE_CLEAR", suppressReboot = false) {
return new Promise((resolve, reject) => {
let params = { resetType: resetType, suppressReboot: suppressReboot}
this.INFO(this.callsign + " resetDevice params: " + JSON.stringify(params));
this.thunder.call(this.callsign, 'resetDevice', params).then(result => {
No description provided.