Skip to content

RDKEAPPRT - 795 Factory reset is not removing installed apps, application catalogue credentials,saved WiFi details, Audio and Video settings #202

Merged
suryag23 merged 10 commits into
developfrom
795
Jun 9, 2026
Merged

RDKEAPPRT - 795 Factory reset is not removing installed apps, application catalogue credentials,saved WiFi details, Audio and Video settings #202
suryag23 merged 10 commits into
developfrom
795

Conversation

@suryag23

@suryag23 suryag23 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

suryag23 added 2 commits June 8, 2026 12:25
Copilot AI review requested due to automatic review settings June 8, 2026 06:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Ref UI version to 6.0.14 and changes the Factory Reset flow to rely on the Warehouse plugin’s resetDevice() (defaulting to WAREHOUSE_CLEAR) so that factory reset more thoroughly clears device state (e.g., installed apps / credentials / settings) compared to the previous UI-driven cleanup + reboot sequence.

Changes:

  • Bump Ref UI version from 6.0.13 to 6.0.14 in package config and app settings.
  • Simplify factory reset confirmation logic to end with Warehouse.resetDevice() instead of performing multiple targeted resets and a direct reboot.
  • Change Warehouse API resetDevice() default reset type to WAREHOUSE_CLEAR.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
bolt/package-configs/com.rdkcentral.refui.json Version bump to 6.0.14.
accelerator-home-ui/src/screens/OtherSettingsScreens/FactoryResetConfirmationScreen.js Factory reset flow now delegates device clearing to Warehouse resetDevice().
accelerator-home-ui/src/api/WarehouseApis.js Changes default reset type for resetDevice() to WAREHOUSE_CLEAR.
accelerator-home-ui/settings.json Version bump to 6.0.14.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread accelerator-home-ui/src/api/WarehouseApis.js Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

accelerator-home-ui/src/api/WarehouseApis.js:128

  • resetDevice() resolves and then immediately calls reject(false) unconditionally (missing else/return). This makes the promise logic incorrect and can cause confusing behavior for callers that rely on rejection for failures.
  resetDevice(resetType = "WAREHOUSE_CLEAR", suppressReboot = false) {
    return new Promise((resolve, reject) => {
      let params = { resetType: resetType, suppressReboot: suppressReboot}
      this.INFO(this.callsign + " resetDevice params: " + JSON.stringify(params));
      this.thunder.call(this.callsign, 'resetDevice', params).then(result => {

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

accelerator-home-ui/src/api/WarehouseApis.js:128

  • Inside resetDevice(), the .then() handler calls resolve(...) but then unconditionally calls reject(false) on the next line. Even though subsequent Promise settlements are ignored by JS, this is misleading and makes the control flow harder to reason about (and can mask future changes if additional logic is added). Use an explicit else/return to only reject on failure.
  resetDevice(resetType = "WAREHOUSE_CLEAR", suppressReboot = false) {
    return new Promise((resolve, reject) => {
      let params = { resetType: resetType, suppressReboot: suppressReboot}
      this.INFO(this.callsign + " resetDevice params: " + JSON.stringify(params));
      this.thunder.call(this.callsign, 'resetDevice', params).then(result => {

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread accelerator-home-ui/src/api/WarehouseApis.js
@suryag23 suryag23 requested review from astolcenburg and Copilot and removed request for Copilot June 8, 2026 09:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@suryag23 suryag23 requested a review from yashaswini-rk June 8, 2026 13:35

@yashaswini-rk yashaswini-rk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@suryag23 suryag23 merged commit 68f72de into develop Jun 9, 2026
7 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
@suryag23 suryag23 deleted the 795 branch June 10, 2026 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants