Handle race condition crash#520
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
There was a problem hiding this comment.
Pull request overview
This PR aims to address a race-condition crash during media pipeline teardown by adjusting GstGenericPlayer lifetime ordering and adding an additional guard in a callback path.
Changes:
- Added an early
m_gstPlayer.reset()call with explanatory comments about teardown ordering. - Updated
notifyPlaybackInfoto requirem_gstPlayerto be valid before notifying the client (and added a log on the skip path).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Coverage statistics of your commit: |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| void MediaPipelineServerInternal::notifyPlaybackInfo(const PlaybackInfo &playbackInfo) | ||
| { | ||
| if (m_mediaPipelineClient) | ||
| if (m_gstPlayer && m_mediaPipelineClient) | ||
| { | ||
| m_mediaPipelineClient->notifyPlaybackInfo(playbackInfo); | ||
| } | ||
| else | ||
| { | ||
| RIALTO_SERVER_LOG_WARN("notifyPlaybackInfo skipped due to invalid gstPlayer"); | ||
| } |
| RIALTO_SERVER_LOG_DEBUG("entry:"); | ||
|
|
||
|
|
||
| m_mainThread = mainThreadFactory->getMainThread(); |
|
Coverage statistics of your commit: |
…rialto into feature/RDKEMW-18434
|
Coverage statistics of your commit: |
handle race condition