Skip to content

RDKB-58910, RDKB-65211 : Removed Ipv6 product custamisations#124

Open
S-Parthiban-Selvaraj wants to merge 2 commits into
developfrom
feature/wan_Ipv6_address_from_IAPD
Open

RDKB-58910, RDKB-65211 : Removed Ipv6 product custamisations#124
S-Parthiban-Selvaraj wants to merge 2 commits into
developfrom
feature/wan_Ipv6_address_from_IAPD

Conversation

@S-Parthiban-Selvaraj
Copy link
Copy Markdown

@S-Parthiban-Selvaraj S-Parthiban-Selvaraj commented May 28, 2026

Pull request overview

This PR removes Sky partner-specific WAN IPv6 address selection logic from four JST templates. Previously, when PartnerId started with sky-, the code used getFirstDownstreamIpInterface() to enumerate WAN IPv6 addresses; now all partners uniformly use getFirstUpstreamIpInterface(). This aligns these pages with similar pages already using upstream-only enumeration (e.g., DPoE.jst, captiveportal.jst).

Changes:

  • Removed Sky-specific if/else branches that used $fistDSif for WAN IPv6 enumeration on network setup and connection status pages.
  • Consolidated to a single upstream-interface IPv6 enumeration loop on both xb3 and xb6 variants.
  • Removed the now-unused $partnerId lookup in the two connection status files.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
source/Styles/xb3/jst/network_setup.jst Drop Sky downstream-interface branch; always use upstream interface for WAN IPv6/link-local/lease enumeration.
source/Styles/xb6/jst/network_setup.jst Same consolidation as xb3 network_setup.
source/Styles/xb3/jst/connection_status.jst Remove Sky branch and unused $partnerId lookup; single upstream-interface loop for WAN IPv6.
source/Styles/xb6/jst/connection_status_onewifi.jst Same consolidation as xb3 connection_status (no break after match, matching prior behavior).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings May 28, 2026 15:48
@S-Parthiban-Selvaraj S-Parthiban-Selvaraj requested review from a team as code owners May 28, 2026 15:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes Sky partner-specific WAN IPv6 address selection logic from four JST templates. Previously, when PartnerId started with sky-, the code used getFirstDownstreamIpInterface() to enumerate WAN IPv6 addresses; now all partners uniformly use getFirstUpstreamIpInterface(). This aligns these pages with similar pages already using upstream-only enumeration (e.g., DPoE.jst, captiveportal.jst).

Changes:

  • Removed Sky-specific if/else branches that used $fistDSif for WAN IPv6 enumeration on network setup and connection status pages.
  • Consolidated to a single upstream-interface IPv6 enumeration loop on both xb3 and xb6 variants.
  • Removed the now-unused $partnerId lookup in the two connection status files.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
source/Styles/xb3/jst/network_setup.jst Drop Sky downstream-interface branch; always use upstream interface for WAN IPv6/link-local/lease enumeration.
source/Styles/xb6/jst/network_setup.jst Same consolidation as xb3 network_setup.
source/Styles/xb3/jst/connection_status.jst Remove Sky branch and unused $partnerId lookup; single upstream-interface loop for WAN IPv6.
source/Styles/xb6/jst/connection_status_onewifi.jst Same consolidation as xb3 connection_status (no break after match, matching prior behavior).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants