RDKB-58910, RDKB-65211 : Removed Ipv6 product custamisations#124
RDKB-58910, RDKB-65211 : Removed Ipv6 product custamisations#124S-Parthiban-Selvaraj wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes Sky partner-specific WAN IPv6 address selection logic from four JST templates. Previously, when PartnerId started with sky-, the code used getFirstDownstreamIpInterface() to enumerate WAN IPv6 addresses; now all partners uniformly use getFirstUpstreamIpInterface(). This aligns these pages with similar pages already using upstream-only enumeration (e.g., DPoE.jst, captiveportal.jst).
Changes:
- Removed Sky-specific
if/elsebranches that used$fistDSiffor WAN IPv6 enumeration on network setup and connection status pages. - Consolidated to a single upstream-interface IPv6 enumeration loop on both xb3 and xb6 variants.
- Removed the now-unused
$partnerIdlookup in the two connection status files.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/Styles/xb3/jst/network_setup.jst | Drop Sky downstream-interface branch; always use upstream interface for WAN IPv6/link-local/lease enumeration. |
| source/Styles/xb6/jst/network_setup.jst | Same consolidation as xb3 network_setup. |
| source/Styles/xb3/jst/connection_status.jst | Remove Sky branch and unused $partnerId lookup; single upstream-interface loop for WAN IPv6. |
| source/Styles/xb6/jst/connection_status_onewifi.jst | Same consolidation as xb3 connection_status (no break after match, matching prior behavior). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Pull request overview
This PR removes Sky partner-specific WAN IPv6 address selection logic from four JST templates. Previously, when
PartnerIdstarted withsky-, the code usedgetFirstDownstreamIpInterface()to enumerate WAN IPv6 addresses; now all partners uniformly usegetFirstUpstreamIpInterface(). This aligns these pages with similar pages already using upstream-only enumeration (e.g.,DPoE.jst,captiveportal.jst).Changes:
if/elsebranches that used$fistDSiffor WAN IPv6 enumeration on network setup and connection status pages.$partnerIdlookup in the two connection status files.Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
$partnerIdlookup; single upstream-interface loop for WAN IPv6.breakafter match, matching prior behavior).💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.