Skip to content

fix save_test_history macro to work when a model depends_on a source with the same name#106

Open
akshaykarle wants to merge 6 commits intore-data:mainfrom
akshaykarle:fix-bug-save-history-failure-371
Open

fix save_test_history macro to work when a model depends_on a source with the same name#106
akshaykarle wants to merge 6 commits intore-data:mainfrom
akshaykarle:fix-bug-save-history-failure-371

Conversation

@akshaykarle
Copy link
Copy Markdown
Contributor

@akshaykarle akshaykarle commented Nov 2, 2022

What

Describe what the change is solving
By using the separated source and ref lists, we can ensure that we fetch the correct node name for the test.

How

passing the additional depends_on_nodes parameter to priv_full_name_from_depends fixes the failing error as it now fetches the correct node for the corresponding source or model

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants