Enhance test when wrong metric is set #111
Open
bachng2017 wants to merge 3 commits intore-data:mainfrom
Open
Conversation
Collaborator
|
@bachng2017 thanks for the PR! I tried testing this locally and it looks like the filters query where
case
else true
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Try to solve this issue by query: re-data/re-data#395
How
Implement new test mechanism to check if metric (column) is correct might be an option but here we introduce a solution by sql query only. The query might be a little bit tricky and the solution is not very intuitive.