-
Notifications
You must be signed in to change notification settings - Fork 315
Picker - Upgrade Windows to New Arch using XAML Islands #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Picker - Upgrade Windows to New Arch using XAML Islands #664
Conversation
|
@Naturalclar Please review - windows new arch picker implementation |
sundaramramaswamy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off with some comments. Please address them. LGTM otherwise!
| m_comboBox.HorizontalAlignment(winrt::Microsoft::UI::Xaml::HorizontalAlignment::Stretch); | ||
|
|
||
| // For editable ComboBox, trigger selection change always (not just on commit) | ||
| m_comboBox.SelectionChangedTrigger(winrt::Microsoft::UI::Xaml::Controls::ComboBoxSelectionChangedTrigger::Always); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| m_comboBox.HorizontalAlignment(winrt::Microsoft::UI::Xaml::HorizontalAlignment::Stretch); | |
| // For editable ComboBox, trigger selection change always (not just on commit) | |
| m_comboBox.SelectionChangedTrigger(winrt::Microsoft::UI::Xaml::Controls::ComboBoxSelectionChangedTrigger::Always); | |
| m_comboBox.HorizontalAlignment( | |
| winrt::Microsoft::UI::Xaml::HorizontalAlignment::Stretch); | |
| // For editable ComboBox, trigger selection change always (not just on commit) | |
| m_comboBox.SelectionChangedTrigger( | |
| winrt::Microsoft::UI::Xaml::Controls::ComboBoxSelectionChangedTrigger::Always); |
Minor: fix formatting
| // For editable ComboBox, add items as strings for proper autocomplete behavior | ||
| // For non-editable, use ComboBoxItem for testID support | ||
| if (newProps->editable) { | ||
| m_comboBox.Items().Append(winrt::box_value(winrt::to_hstring(item.label))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| m_comboBox.Items().Append(winrt::box_value(winrt::to_hstring(item.label))); | |
| m_comboBox.Items() | |
| .Append(winrt::box_value(winrt::to_hstring(item.label))); |
Minor: fix formatting.
Overview
This PR upgrades the Windows implementation of the Picker component to use the new architecture based on XAML Islands. The goal is to modernize the component, improve compatibility with recent React Native Windows changes, and ensure better long-term support.
Design and Implementation
XAML Islands Integration
Architecture Changes
Spec File Changes
I have removed the old implementation of windows in “js” directory for Picker.
Testing Instructions
Note
Screenshots and videos
picker_3p_windows.mp4