Fix hermes rolling tag mismatch on SPM - #57931
Closed
ospfranco wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
ospfranco
changed the title
facebook-github-tools
Bot
added
the
Shared with Meta
Contributor
|
This is a duplicate of #57928. we will import and land the other PR as it has arrived before this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The SPM script uses a v1 tag for Hermes. But this tag is a rolling tag, if a new version of hermes is published, then the app compilation fails. This PR aims to implement the same mechanism as Cocoapods where the expected NPM version is first read and then tell SPM to download that specific version.
Changelog:
[IOS] [FIXED] - Fixes SPM downloading hermes V1 rolling tag
Test Plan:
Tests have been adjusted. Disclosure: Mostly AI PR, again I guided it through the necessary changes, but it copied the cocoapods logic on it's own.