Skip to content

Cover textlayoutmanager with Stable API guards (#58312) - #58312

Closed
j-piasecki wants to merge 1 commit into
react:mainfrom
j-piasecki:export-D118630817
Closed

Cover textlayoutmanager with Stable API guards (#58312)#58312
j-piasecki wants to merge 1 commit into
react:mainfrom
j-piasecki:export-D118630817

Conversation

@j-piasecki

@j-piasecki j-piasecki commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary:

Classifies react/renderer/textlayoutmanager:textlayoutmanager as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into RN_STRICT_API now get a warning if they include its headers directly, which they can acknowledge with RN_ALLOW_FRAMEWORKS; without that flag the guards are inert, so no existing build changes behaviour.

Changelog: [Internal]

Differential Revision: D118630817

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2026
@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner p: Facebook Partner: Facebook labels Sep 3, 2026
@meta-codesync

meta-codesync Bot commented Sep 3, 2026

Copy link
Copy Markdown

@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D118630817.

@meta-codesync meta-codesync Bot changed the title Cover textlayoutmanager with Stable API guards Cover textlayoutmanager with Stable API guards (#58312) Sep 4, 2026
j-piasecki added a commit to j-piasecki/react-native that referenced this pull request Sep 4, 2026
Summary:

Classifies `react/renderer/textlayoutmanager:textlayoutmanager` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour.

Changelog: [Internal]

Differential Revision: D118630817
Summary:

Classifies `react/renderer/textlayoutmanager:textlayoutmanager` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour.

Changelog: [Internal]

Differential Revision: D118630817
@meta-codesync meta-codesync Bot closed this in 8f9232b Sep 9, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Sep 9, 2026
@meta-codesync

meta-codesync Bot commented Sep 9, 2026

Copy link
Copy Markdown

This pull request has been merged in 8f9232b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant