-
-
Notifications
You must be signed in to change notification settings - Fork 532
Sync with react.dev @ a1ddcf51 #1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* fix: correct link for RedwoodJS to RedwoodSDK in documentation * fix: update links for React Query and TanStack Start in documentation * fix: update Vite installation command to use TypeScript template * fix: update references from React Query to TanStack Query in documentation
Fixes #8097 The refactored example in the "Chains of computations" section uses an incorrect condition that changes the game logic from the original. The original Effect-based code advances the round after 4 gold cards: - Increments first (0→1, 1→2, 2→3, 3→4) - Then checks `goldCardCount > 3` (true when count is 4) The refactored code with `goldCardCount <= 3` allows 5 gold cards: - Checks before incrementing - Allows counts 0, 1, 2, 3 to increment (4 values) - Advances on the 5th card (when count is 4) This fix changes the condition to `goldCardCount < 3`: - Allows counts 0, 1, 2 to increment (3 values) - Advances on the 4th card (when count is 3) - Matches the original behavior Verified by tracing execution logic and building the docs site locally. Co-authored-by: PaulyBearCoding <PaulyBearCoding@users.noreply.github.com>
…ave-dev` to `—save-dev`) (#8146) * Skip smartypants on TerminalBlock * Improve TerminalBlock HTML tags * Remove unnecessary TerminalBlock escapes from docs * Bump DISK_CACHE_BREAKER
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Size changesDetails📦 Next.js Bundle Analysis for undefinedThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
110.18 KB (🟡 +1 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/404 |
133.82 KB (🟡 +175 B) |
244.01 KB |
/500 |
133.82 KB (🟡 +175 B) |
244 KB |
/[[...markdownPath]] |
136.46 KB (🟡 +175 B) |
246.65 KB |
/errors |
133.96 KB (🟡 +175 B) |
244.14 KB |
/errors/[errorCode] |
133.94 KB (🟡 +175 B) |
244.12 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
bd645f0 to
77cd0fb
Compare
… into sync-a1ddcf51 # Conflicts: # package.json # src/components/Layout/HomeContent.js # src/content/blog/2023/03/22/react-labs-what-we-have-been-working-on-march-2023.md # src/content/blog/2024/05/22/react-conf-2024-recap.md # src/content/blog/2024/12/05/react-19.md # src/content/blog/2025/02/14/sunsetting-create-react-app.md # src/content/blog/index.md # src/content/learn/add-react-to-an-existing-project.md # src/content/learn/build-a-react-app-from-scratch.md # src/content/learn/choosing-the-state-structure.md # src/content/learn/creating-a-react-app.md # src/content/learn/synchronizing-with-effects.md # src/content/learn/typescript.md # src/content/learn/you-might-not-need-an-effect.md # src/content/learn/your-first-component.md # src/content/reference/react-dom/index.md # src/content/reference/react-dom/preinit.md # src/content/reference/react-dom/preinitModule.md # src/content/reference/react-dom/preload.md # src/content/reference/react-dom/preloadModule.md # src/content/reference/react/act.md # src/content/reference/react/addTransitionType.md # src/content/reference/react/index.md # src/content/reference/react/useEffect.md # src/content/reference/react/useId.md # src/content/reference/react/useTransition.md # src/content/reference/rsc/directives.md # src/content/reference/rsc/use-client.md # src/sidebarBlog.json # yarn.lock
….dev Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
이런 다음 Sync로 미룹니다. |
This PR was automatically generated.
Merge changes from react.dev at a1ddcf5
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.