Update the config steps to cache a True result. #12554
Open
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI debugged this and said this, which seems reasonable -- sounds like a race condition on the existance of the config file. AI response: The key issue was: * Before: When the config file was found, it set _show_config_step_executed = True and returned False * On subsequent calls, if _show_config_step_executed existed, it would always return False * But when the config file was NOT found, no cache was set, so the function would re-evaluate on every call This inconsistency led to the wizard thinking a step should exist at one point but not at another, causing the KeyError.
Member
Author
|
Keep seeing this one pop up in Sentry, so would love a peek at this -- I'm not 100% sure it's the issue, but seems worth a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI debugged this and said this, which seems reasonable -- sounds like a race condition on the existance of the config file.
AI response:
Fixes https://read-the-docs.sentry.io/issues/5995127471