Adds observability for the rerankers -latency and error. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the expr reranker implementaton by caching the ast. Bugfix in the implementation of the sorting from the new rerankers. Signed-off-by: Amit Kumar <[email protected]>
Signed-off-by: Amit Kumar <[email protected]>
…deployed libiberty revision. Signed-off-by: Amit Kumar <[email protected]>
…-io#45237) issue: milvus-io#44172, milvus-io#45210, milvus-io#44851 kafka will auto reset the offset to "latest" if the offset is Out-of-range. the recovery of milvus wal cannot read any message from that. So once the offset is out-of-range, kafka should read from eariest to read the latest uncleared data. https://kafka.apache.org/documentation/#consumerconfigs_auto.offset.reset Signed-off-by: chyezh <[email protected]>
…t the search has output fields (for other rerankers like the decay reranker), it crashes trying to prepare field data it doesn't need. Signed-off-by: Amit Kumar <[email protected]>
Signed-off-by: Amit Kumar <[email protected]>
Signed-off-by: Amit Kumar <[email protected]>
Signed-off-by: Amit Kumar <[email protected]>
Signed-off-by: Amit Kumar <[email protected]>
Signed-off-by: Amit Kumar <[email protected]>
Signed-off-by: Amit Kumar <[email protected]>
Signed-off-by: Amit Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the expr reranker implementation by caching the ast.
Bugfix in the implementation of the sorting from the new rerankers.
The part that does the query node reranking is the
attach RerankFunction in task_search.go(Proxy Node)WithRerank(Query Node)EncodeSearchResultDataand returns the Search Result with the query nodeCloses #
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks