Adding PCP shims to the wrapper, using the "one big archive" approach #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCP traces are preserved alongside the main results
|
This relates to RPOPC-579 |
dvalinrh
added
the
group_review_lgtm
kdvalin
approved these changes
Sep 9, 2025
coremark/coremark_run
Outdated
|
|
||
| # Get PCP setup if we're using it | ||
| if [[ $to_use_pcp -eq 1 ]]; then | ||
| # rm -rf ${curdir}/pcp # PCP doesn't seem to like it if there's already an archive in the place I want to put one |
dvalinrh
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the shims necessary to gather PCP traces using the "one big archive" approach (instead of per-iteration).
Traces are preserved alongside the main results
PCP data gathering is disabled by default for now, use --use_pcp to enable
Before/After Comparison
Before: no PCP support in the wrapper
After: PCP data gathering is supported
Clerical Stuff
This closes #56
Relates to JIRA: RPOPC-579