Add package manangement to wrapper #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add json file for package_tool
Add handling of package dependencies based on what's in the wrapper's json file
kdvalin
requested changes
Oct 21, 2025
kdvalin
requested changes
Oct 28, 2025
kdvalin
added
the
group_review_lgtm
Co-authored-by: Keith Valin <[email protected]>
frival
reviewed
Oct 28, 2025
io_burst/burst_io.sh
Outdated
| done | ||
|
|
||
| # Install needed packages based on what's listed in the wrapper's json file | ||
| ${TOOLS_BIN}/package_tool --no_packages $to_no_pkg_install -wrapper_config ${run_dir}/io_burst-wrapper.json |
There was a problem hiding this comment.
Is it -wrapper_config or --wrapper_config?
Contributor
Author
There was a problem hiding this comment.
That's where the extra dash came from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds handling of package dependencies to the wrapper based on what's in the wrapper's json file, and adds said json file.
Before/After Comparison
Before: packages are installed by the parent harness
After: packages are installed by the wrapper based on contents of associated json file.
I watched the sequence work properly on rhel and ubuntu
Clerical Stuff
This closes #15
Relates to JIRA: RPOPC-648