Skip to content

Conversation

@xdavidson
Copy link
Collaborator

Currently filepath is not printed out as part of standard output when Uploader receives a http response code 304. This PR allows us to see the filepath on stdout for 304.

@xdavidson xdavidson requested a review from carlosmunoz August 20, 2020 18:13
@codecov-commenter
Copy link

Codecov Report

Merging #376 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #376      +/-   ##
============================================
+ Coverage     58.80%   58.88%   +0.08%     
- Complexity      444      449       +5     
============================================
  Files           113      116       +3     
  Lines          3663     3675      +12     
  Branches        524      526       +2     
============================================
+ Hits           2154     2164      +10     
- Misses         1403     1406       +3     
+ Partials        106      105       -1     
Flag Coverage Δ Complexity Δ
#java 58.88% <ø> (+0.08%) 449.00 <ø> (+5.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../java/com/redhat/pantheon/model/module/Module.java 80.00% <0.00%> (-20.00%) 4.00% <0.00%> (-1.00%)
...om/redhat/pantheon/extension/HydraIntegration.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...edhat/pantheon/asciidoctor/AsciidoctorService.java 3.90% <0.00%> (ø) 3.00% <0.00%> (ø%)
...t/pantheon/model/api/SlingModelAdapterFactory.java 93.33% <0.00%> (ø) 6.00% <0.00%> (ø%)
.../extension/events/ModuleVersionPublishedEvent.java
...xtension/events/ModuleVersionUnpublishedEvent.java
...dhat/pantheon/servlet/module/UnpublishVersion.java
...tension/events/ModuleVersionPublishStateEvent.java
...t/pantheon/servlet/module/PublishDraftVersion.java
...m/redhat/pantheon/servlet/PublishDraftVersion.java 50.00% <0.00%> (ø) 12.00% <0.00%> (?%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f607fd...b50238c. Read the comment docs.

@aprajshekhar
Copy link
Contributor

@xdavidson it will be great if you could add the same change to https://github.com/redhataccess/pantheon-uploader as well. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants