Skip to content

Conversation

@sazzad16
Copy link
Contributor

No description provided.

@sazzad16 sazzad16 added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label May 14, 2023
@sazzad16 sazzad16 requested a review from chayim May 14, 2023 08:41
sazzad16 added 7 commits May 15, 2023 19:19
"No need to declare vs. version 4. Should be self-evident."
"For all of these I think you should change to
```getAgeSeconds() in AccessControlLogEntry``` now returns `Double` instead of `String` .

Then, we can sort alphabetically too - and make it easier for users."
"`quit() method has been removed from `Connection` and ServerCommands implementations`"
@sazzad16 sazzad16 requested a review from chayim May 15, 2023 13:42
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d94aa4d) 64.70% compared to head (74859c6) 64.71%.

❗ Current head 74859c6 differs from pull request most recent head 7a11e53. Consider uploading reports for the commit 7a11e53 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##                5.0    #3415   +/-   ##
=========================================
  Coverage     64.70%   64.71%           
- Complexity     4567     4568    +1     
=========================================
  Files           274      274           
  Lines         15242    15241    -1     
  Branches        980      980           
=========================================
  Hits           9863     9863           
  Misses         4966     4966           
+ Partials        413      412    -1     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Jedis.java 85.44% <ø> (ø)
...ava/redis/clients/jedis/MultiNodePipelineBase.java 21.87% <ø> (ø)
src/main/java/redis/clients/jedis/Pipeline.java 16.78% <ø> (ø)
...main/java/redis/clients/jedis/TransactionBase.java 12.01% <ø> (ø)
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 71.42% <ø> (ø)
...a/redis/clients/jedis/commands/StreamCommands.java 100.00% <ø> (ø)
...clients/jedis/commands/StreamPipelineCommands.java 0.00% <ø> (ø)
...is/clients/jedis/resps/StreamConsumerFullInfo.java 76.92% <ø> (ø)
...java/redis/clients/jedis/resps/StreamFullInfo.java 93.75% <ø> (ø)
...redis/clients/jedis/resps/StreamGroupFullInfo.java 80.00% <ø> (ø)
... and 6 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sazzad16 sazzad16 merged commit 8ffd10d into redis:5.0 May 15, 2023
@sazzad16 sazzad16 deleted the break-list branch May 15, 2023 13:45
@sazzad16 sazzad16 added this to the 5.0.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants