Client setinfo ignore all exception #3449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangbodong22011
commented
Jun 1, 2023
yangbodong22011
force-pushed
the
fix-client-report-name
branch
2 times, most recently
from
d5dbf87 to
160cb28
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #3449 +/- ##
============================================
- Coverage 71.27% 71.23% -0.05%
- Complexity 4736 4740 +4
============================================
Files 274 275 +1
Lines 14697 14738 +41
Branches 991 989 -2
============================================
+ Hits 10476 10499 +23
- Misses 3789 3808 +19
+ Partials 432 431 -1
☔ View full report in Codecov by Sentry. |
sazzad16
reviewed
Jun 1, 2023
sazzad16
suggested changes
Jun 1, 2023
src/main/java/redis/clients/jedis/DefaultJedisClientConfig.java
Outdated
Show resolved
Hide resolved
yangbodong22011
force-pushed
the
fix-client-report-name
branch
3 times, most recently
from
2929574 to
3895341
Compare
sazzad16
reviewed
Jun 2, 2023
yangbodong22011
force-pushed
the
fix-client-report-name
branch
from
3895341 to
b4c9df4
Compare
sazzad16
suggested changes
Jun 3, 2023
Check the character legality of clientName in advance through validateClientInfo, so that character exceptions are ignored in initializeFromClientConfig. The remaining errors, NOAUTH, UNKNOWN command, SYNTAX error, NOPREM should be ignored.
yangbodong22011
force-pushed
the
fix-client-report-name
branch
from
b4c9df4 to
e6910e5
Compare
sazzad16
approved these changes
Jun 5, 2023
sazzad16
pushed a commit
to sazzad16/jedis
that referenced
this pull request
Jun 5, 2023
This PR contains the following changes: 1. Check the character legality of clientName in advance through `validateClientInfo`, so that character exceptions are ignored in `initializeFromClientConfig`. 2. Move the `select` command out of the fire-and-forget message (we care about its return value). 3. For the test of RedisCredentials, we gave it "invalidPass" for the first time to make it fail the verification instead of skipping the verification.
sazzad16
added a commit
that referenced
this pull request
Jun 6, 2023
This PR contains the following changes: 1. Check the character legality of clientName in advance through `validateClientInfo`, so that character exceptions are ignored in `initializeFromClientConfig`. 2. Move the `select` command out of the fire-and-forget message (we care about its return value). 3. For the test of RedisCredentials, we gave it "invalidPass" for the first time to make it fail the verification instead of skipping the verification. --------- Co-authored-by: bodong.ybd <[email protected]>
sazzad16
added a commit
that referenced
this pull request
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes (fixes #3438):
validateClientInfo, so that character exceptions are ignored ininitializeFromClientConfig.selectcommand out of the fire-and-forget message (we care about its return value).