-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add support for CAS/CAD commands #4353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 281 files ± 0 281 suites ±0 11m 48s ⏱️ -4s Results for commit cbd70f3. ± Comparison against base commit c18881e. This pull request removes 3 and adds 78 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should revert
| /** | ||
| * Compare-and-delete: delete key if optional value/digest condition matches. | ||
| * @return 1 if the key was deleted, 0 otherwise | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code for removal
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some extra lines
| * Experimental: SET+GET with SetParams and compare-and-* condition. | ||
| */ | ||
| @Experimental | ||
| String setGet(String key, String value, SetParams params, ValueCondition condition); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add new params directly to SetParams and avoid having more overloaded methods.
considering that actually CAS is extension to existing GET command
| * Experimental: Compare-and-delete guarded by value/digest condition. | ||
| */ | ||
| @Experimental | ||
| long delex(byte[] key, ValueCondition condition); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the spec
DELEX is a new command
I think we should go with :
DelExParams with the same ifeq/ifne/ifdeq/ifdne methods from SetParams.
|
closed in favor of #4363 |
resolves #4341