Fix packaging bug: include generated sync code in wheel (v1.0.6)#803
Merged
Fix packaging bug: include generated sync code in wheel (v1.0.6)#803
Conversation
- Add artifacts option to pyproject.toml so hatchling includes redis_om/ files that are in .gitignore (generated by make sync) - Fix supports_hash_field_expiration() to check sync Redis class in generated sync code via post-processing in make_sync.py - Bump version to 1.0.6
ee6332b to
94e464a
Compare
Collaborator
Author
|
This was a fallout from the move to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the packaging bug in v1.0.5 where the
redis_om(sync) module only contained__init__.pybut no other files.Root Causes
Hatchling respects
.gitignoreby default: The.gitignorefile hasredis_om/*(with exceptions for placeholder files). Whenmake syncgenerates the sync code during CI, hatchling excluded those files from the wheel because they're gitignored.supports_hash_field_expiration()bug: The function checksredis_lib.asyncio.Redis.hexpirein both async and sync versions. The sync version should checkredis_lib.Redis.hexpireinstead.Changes
pyproject.tomlAdded
artifactsoption to include generated files that are in.gitignore:make_sync.pyAdded post-processing to fix the
supports_hash_field_expiration()function by replacingredis_lib.asyncio.Rediswithredis_lib.Redisin the generated sync code.Verification
aredis_om/andredis_om/supports_hash_field_expiration()works correctly in both modules