feat: migrate shadowlink API to v1 with PREVIEW visibility #2059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add shadowlink.proto to dataplane/v1 (keeping v1alpha3 unchanged) - Update HTTP endpoints to /v1/shadow-links/* (cloud-compatible paths) - Add google.api.api_visibility PREVIEW restriction to v1 service - Generate protobuf files for backend (Go) - Update OpenAPI specs to include v1 endpoints - Frontend continues using v1alpha3 for now
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
simon0191
approved these changes
Dec 3, 2025
andresaristizabal
requested changes
Dec 3, 2025
frontend/src/components/pages/shadowlinks/details/config/configuration-shadowing.tsx
Show resolved
Hide resolved
- Add PREVIEW visibility annotation to v1 shadowlink API - Create v1-specific FailOverRequest message to avoid protobuf conflicts - Generate backend protobuf files for v1 API - Both v1alpha3 and v1 APIs coexist for backward compatibility - Frontend continues to use v1alpha3
c-julin
force-pushed
the
feat/move-shadowlink-to-v1
branch
from
d2d513e to
b8db1f6
Compare
andresaristizabal
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the shadowlink API from v1alpha3 to v1 while maintaining backward compatibility. The v1 API includes PREVIEW visibility restrictions and cloud-compatible endpoint paths.
Key Changes
/v1/shadow-links/*with hyphen)Technical Details
google.api.api_visibilitywith PREVIEW restrictioncore.admin.v2.FailOverRequesttype (lint exceptions added)Breaking Changes
None - this is purely additive. Existing v1alpha3 API remains functional.