fix: apply ID to debounceinput even when it is a var.#6105
Merged
masenf merged 1 commit intoreflex-dev:mainfrom Jan 29, 2026
Merged
fix: apply ID to debounceinput even when it is a var.#6105masenf merged 1 commit intoreflex-dev:mainfrom
masenf merged 1 commit intoreflex-dev:mainfrom
Conversation
Contributor
Greptile OverviewGreptile SummaryFixed a bug where Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User Code
participant DI as DebounceInput.create()
participant Child as Child Component (rx.input)
participant Props as Props Dict
User->>DI: create(child=rx.input(id=Var.create("myid")))
DI->>Child: Get child.id
Child-->>DI: Returns Var("myid")
alt Before Fix
DI->>Props: Check if child_ref exists
Note over DI,Props: Only copy ID if ref exists<br/>(indentation made it conditional)
DI->>Props: props["id"] = child.id (skipped!)
end
alt After Fix
DI->>Props: Check if child_ref exists
DI->>Props: Set input_ref if needed
DI->>Props: if child.id is not None
DI->>Props: props["id"] = child.id ✓
end
DI-->>User: Returns configured DebounceInput
|
Contributor
|
ref #3564 |
masenf
approved these changes
Jan 29, 2026
Contributor
Author
Ah, thanks! You are right. I linked the wrong issue in the description. Corrected now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
When using
valueandon_changeand anrx.Varasinput.idprop, it will not be correctly set on the input, because debounce input only copies IDs that are not vars.We had some problems with IDs before. Maybe it's about time for #3564
Minimal example with working and not working input. Interestingly the var in evaluated in both cases.