Skip to content

[bugfix] Enforce strict POSIX names for environment variable names in the configuration - #3724

Merged
vkarak merged 1 commit into
reframe-hpc:masterfrom
vkarak:bugfix/config-envvars-alphanum
Sep 15, 2026
Merged

vkarak merged 1 commit into
reframe-hpc:masterfrom
vkarak:bugfix/config-envvars-alphanum

Conversation

@vkarak

@vkarak vkarak commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This is a bug introduced in 3.11 by #2479 and it practically allows invalid names to be defined as environment variable names in the various env_vars configuration options.

@vkarak vkarak added this to the ReFrame 4.10.4 milestone Sep 9, 2026
@vkarak
vkarak requested review from ekouts and victorusu September 9, 2026 21:53
@vkarak vkarak self-assigned this Sep 9, 2026
@vkarak vkarak changed the title [bugfix] Enforce strict POSIX names for environment variable names in config [bugfix] Enforce strict POSIX names for environment variable names in the configuration Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (b79872a) to head (50d5986).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3724   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files          62       62           
  Lines       13802    13802           
=======================================
  Hits        12684    12684           
  Misses       1118     1118           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@victorusu victorusu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in ReFrame Backlog Sep 15, 2026
Signed-off-by: Vasileios Karakasis <vkarak@gmail.com>
@vkarak
vkarak force-pushed the bugfix/config-envvars-alphanum branch from 2219c53 to 50d5986 Compare September 15, 2026 12:31
@vkarak
vkarak enabled auto-merge September 15, 2026 12:31
@vkarak
vkarak merged commit f583c9b into reframe-hpc:master Sep 15, 2026
32 of 33 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in ReFrame Backlog Sep 15, 2026
@vkarak
vkarak deleted the bugfix/config-envvars-alphanum branch September 15, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants